fix(workspace): propagate findWorkspace errors and fix list append bug#124
Conversation
findWorkspace() was swallowing List() errors and returning nil, causing misleading 'workspace not found' messages when the real error was e.g. a connection timeout. Now returns the actual error to callers. Also fixes list.go appending the entire localWorkspaces slice instead of the single localWorkspace loop variable during cleanup filtering.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 0 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
findWorkspace()now returns errors fromList()andSaveWorkspaceConfig()instead of swallowing them and returning nil. This surfaces the real error (e.g. connection timeout) to the user instead of a misleading "workspace not found" message. CallersGet()andfindWorkspaceByArgs()propagate the error;Exists()andresolveWorkspace()explicitly discard it since they only need existence checks.list.go:79appending the entirelocalWorkspacesslice instead of the singlelocalWorkspaceloop variable, which caused duplicate entries in the cleaned workspace list.